Re: [PATCH] memory: tegra: Deduplicate rate request management code

[Krzysztof Kozlowski]

On 17/02/2026 05:22, Mikko Perttunen wrote:
> On Friday, February 13, 2026 7:24 PM Krzysztof Kozlowski wrote:
>> On 06/02/2026 03:54, Mikko Perttunen wrote:
>>> As is, the EMC drivers for each 32-bit platform contain almost
>>> identical duplicated code for aggregating rate requests. Move this
>>> code out to a shared tegra-emc-common file to reduce duplication.
>>>
>>> Signed-off-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
>>> ---
>>> This patch is on top of 'memory: tegra: Add Tegra114 EMC driver'
>>
>> If that patch is not merged, then this should be reversed. First you
>> remove duplication then you add smaller new patch. Not vice versa, where
>> you add duplicated code just to remove it.
> 
> The code is already duplicated multiple times before. 

That's the meaning of duplication... and adding more duplicated code is
obviously not proper choice.


> The Tegra114 driver doesn't change the situation in any significant way. Sequencing in this way is just easier rather than disrupting that - more important - series.

Fix your email so message will be properly wrapped.

Also in the future, please use normal ways to express dependencies - by
lore links or b4 deps.


Best regards,
Krzysztof