Re: [PATCH] memory: tegra: Deduplicate rate request management code

[Mikko Perttunen]

On Tuesday, February 17, 2026 4:14 PM Krzysztof Kozlowski wrote:
> On 17/02/2026 05:22, Mikko Perttunen wrote:
> > On Friday, February 13, 2026 7:24 PM Krzysztof Kozlowski wrote:
> >> On 06/02/2026 03:54, Mikko Perttunen wrote:
> >>> As is, the EMC drivers for each 32-bit platform contain almost
> >>> identical duplicated code for aggregating rate requests. Move this
> >>> code out to a shared tegra-emc-common file to reduce duplication.
> >>> 
> >>> Signed-off-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> >>> ---
> >>> This patch is on top of 'memory: tegra: Add Tegra114 EMC driver'
> >> 
> >> If that patch is not merged, then this should be reversed. First you
> >> remove duplication then you add smaller new patch. Not vice versa, where
> >> you add duplicated code just to remove it.
> > 
> > The code is already duplicated multiple times before.
> 
> That's the meaning of duplication... and adding more duplicated code is
> obviously not proper choice.

I understand you want the cleanup to be done first, and that's fine and you 
decide -- and more duplicated code is obviously not good, but I don't think 
the order these series should go in is obvious. I'm only saying that because 
to me your wording reads as accusing me of making obviously bad arguments, and 
it's not making my day better.

> 
> > The Tegra114 driver doesn't change the situation in any significant way.
> > Sequencing in this way is just easier rather than disrupting that - more
> > important - series.
> Fix your email so message will be properly wrapped.

It seems some update must have overridden my email config. I think I have 
fixed it.

> 
> Also in the future, please use normal ways to express dependencies - by
> lore links or b4 deps.

I did use b4 deps.

> 
> 
> Best regards,
> Krzysztof

Cheers,
Mikko