Re: [PATCH RESEND net v1 1/2] octeon_ep: avoid compiler and IQ/OQ reordering

[Paolo Abeni]

On 2/12/26 1:16 PM, Vimlesh Kumar wrote:
> Utilize READ_ONCE and WRITE_ONCE APIs for IO queue Tx/Rx
> variable access to prevent compiler optimization and reordering.

You must include into the commit message a more detalied description of
what could possibly go wrong and way. Also why wmb/rmb are not enough?

AFAICS this is the only driver requiring such annotations to cooperate
with the H/W and/or the firmware.

> Additionally, ensure IO queue OUT/IN_CNT registers are flushed
> by performing a read-back after writing.
> 
> Relocate IQ/OQ IN/OUT_CNTS updates to occur before NAPI completion,
> and replace napi_complete with napi_complete_done.

This looks like a separate change, and again requires a more complete
explaination of what could possibly go wrong and why.

/P