Re: [PATCH] rust: hrtimer: document handle based design rationale
From: Boqun Feng
Date: Wed Feb 18 2026 - 15:16:04 EST
On Wed, Feb 18, 2026 at 08:31:06PM +0100, Andreas Hindborg wrote:
> "Boqun Feng" <boqun@xxxxxxxxxx> writes:
>
> > On Sun, Feb 15, 2026 at 09:36:04PM +0100, Andreas Hindborg wrote:
> >> Add implementation notes explaining why the hrtimer abstraction uses a
> >> handle based approach.
> >>
> >> Signed-off-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
> >
> > Thanks for adding this!
> >
> > Reviewed-by: Boqun Feng <boqun@xxxxxxxxxx>
> >
> > However I feel these are not just implementation details. They are the
> > design decision we made because of the limitation you mentioned. Maybe
> > make them "//!" doc comment and just put them as a separate section that
> > describes the necessity of handles? Thoughts?
>
> I don't think these details are important for the reader of the API? If
> you just want to use a timer, this is not something you want to read
> through.
>
Fair enough ;-)
Regards,
Boqun
>
> Best regards,
> Andreas Hindborg
>
>
>