Re: [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC

[Niklas Cassel]

On Fri, Feb 20, 2026 at 11:42:08AM +0100, Andy Shevchenko wrote:
> As noticed in the discussion [1] the Baikal SoC and platforms
> are not going to be finalized, hence remove stale code.
> 
> Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@xxxxxxxxxxxxx/ [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/ata/Kconfig    |  1 -
>  drivers/ata/ahci_dwc.c | 54 ------------------------------------------
>  2 files changed, 55 deletions(-)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 2349bca136e0..fff305ec1e78 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -194,7 +194,6 @@ config AHCI_DM816
>  config AHCI_DWC
>  	tristate "Synopsys DWC AHCI SATA support"
>  	select SATA_HOST
> -	select MFD_SYSCON if (MIPS_BAIKAL_T1 || COMPILE_TEST)
>  	help
>  	  This option enables support for the Synopsys DWC AHCI SATA
>  	  controller implementation.
> diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c
> index 64abf865bb67..436041c57f73 100644
> --- a/drivers/ata/ahci_dwc.c
> +++ b/drivers/ata/ahci_dwc.c
> @@ -13,7 +13,6 @@
>  #include <linux/kernel.h>
>  #include <linux/libata.h>
>  #include <linux/log2.h>
> -#include <linux/mfd/syscon.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>

Since you are removing the, from what I can tell, unused syscon.h, I think
we should remove the, from what I can tell, unused linux/regmap.h include
as well.

(snip)

>  static const struct of_device_id ahci_dwc_of_match[] = {
>  	{ .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
>  	{ .compatible = "snps,spear-ahci", &ahci_dwc_plat },
> -	{ .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },

If we are dropping support for baikal,bt1-ahci, then I think it makes sense
to remove Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
as well.


Kind regards,
Niklas