Re: [PATCH v1 1/1] ata: ahci-dwc: Remove not-going-to-be-supported code for Baikal SoC

[Andy Shevchenko]

On Fri, Feb 20, 2026 at 02:27:28PM +0100, Niklas Cassel wrote:
> On Fri, Feb 20, 2026 at 11:42:08AM +0100, Andy Shevchenko wrote:
> > As noticed in the discussion [1] the Baikal SoC and platforms
> > are not going to be finalized, hence remove stale code.

...

> >  #include <linux/kernel.h>
> >  #include <linux/libata.h>
> >  #include <linux/log2.h>
> > -#include <linux/mfd/syscon.h>
> >  #include <linux/module.h>
> >  #include <linux/of.h>
> >  #include <linux/platform_device.h>
> 
> Since you are removing the, from what I can tell, unused syscon.h, I think
> we should remove the, from what I can tell, unused linux/regmap.h include
> as well.
> 
> (snip)
> 
> >  static const struct of_device_id ahci_dwc_of_match[] = {
> >  	{ .compatible = "snps,dwc-ahci", &ahci_dwc_plat },
> >  	{ .compatible = "snps,spear-ahci", &ahci_dwc_plat },
> > -	{ .compatible = "baikal,bt1-ahci", &ahci_bt1_plat },
> 
> If we are dropping support for baikal,bt1-ahci, then I think it makes sense
> to remove Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
> as well.

Thanks, I have just sent a v2 with the suggested changes.

-- 
With Best Regards,
Andy Shevchenko