Re: [PATCH] regulator: tps65185: check devm_kzalloc() result in probe

[Eric_Terminal]

Hi Liam, Mark,

My apologies for using the pseudonym "Eric-Terminal" in the previous
submission of this patch. I am a newcomer and was not aware of the
Linux kernel's policy regarding real names in Signed-off-by tags.

I have just resubmitted the patch with my real name, Yufan Chen
<ericterminal@xxxxxxxxx>, and have added the correct Signed-off-by
line. I've also ensured the formatting follows the community
standards.

Thank you for your patience as I learn the contribution process.

Best regards,
Yufan Chen

On Sun, Feb 22, 2026 at 6:40 PM Yufan Chen <ericterminal@xxxxxxxxx> wrote:
>
> tps65185_probe() dereferences the allocation result immediately by using data->regmap. If devm_kzalloc() returns NULL under memory pressure, this leads to a NULL pointer dereference.
>
> Add the missing allocation check and return -ENOMEM on failure.
>
> Signed-off-by: Yufan Chen <ericterminal@xxxxxxxxx>
> ---
>  drivers/regulator/tps65185.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/regulator/tps65185.c b/drivers/regulator/tps65185.c
> index 3286c9ab3..786622d8d 100644
> --- a/drivers/regulator/tps65185.c
> +++ b/drivers/regulator/tps65185.c
> @@ -332,6 +332,9 @@ static int tps65185_probe(struct i2c_client *client)
>         int i;
>
>         data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
> +       if (!data)
> +               return -ENOMEM;
> +
>         data->regmap = devm_regmap_init_i2c(client, &regmap_config);
>         if (IS_ERR(data->regmap))
>                 return dev_err_probe(&client->dev, PTR_ERR(data->regmap),
> --
> 2.47.3
>