Re: [RFC PATCH 2/4] PCI/DOE: Move common definitions to the header file

[Lukas Wunner]

On Fri, Feb 13, 2026 at 06:06:01PM +0530, Aksh Garg wrote:
> Move common macros and structures from drivers/pci/doe.c to
> include/linux/pci-doe.h to allow reuse across root complex and
> endpoint DOE implementations.

Please use drivers/pci/pci.h for declarations that need not be visible
outside the PCI core.

There are users of pci_doe() & pci_find_doe_mailbox() outside the
PCI core, that's the (only) reason the declarations are in
include/linux/pci-doe.h.

> Also add CONFIG_PCI_DOE guards around the root complex DOE APIs to
> maintain proper conditional compilation.

It's not clear to me why these empty inlines are needed, please drop
them or provide an explanation in the commit message.

Thanks,

Lukas