Re: [RFC PATCH 2/4] PCI/DOE: Move common definitions to the header file

[Aksh Garg]

Hi Lukas,

On 22/02/26 18:31, Lukas Wunner wrote:
> On Fri, Feb 13, 2026 at 06:06:01PM +0530, Aksh Garg wrote:
> > Move common macros and structures from drivers/pci/doe.c to
> > include/linux/pci-doe.h to allow reuse across root complex and
> > endpoint DOE implementations.
>
> Please use drivers/pci/pci.h for declarations that need not be visible
> outside the PCI core.
>
> There are users of pci_doe() & pci_find_doe_mailbox() outside the
> PCI core, that's the (only) reason the declarations are in
> include/linux/pci-doe.h.

Thank you for the feedback. I will follow this convention in the future
patch series.

> > Also add CONFIG_PCI_DOE guards around the root complex DOE APIs to
> > maintain proper conditional compilation.
>
> It's not clear to me why these empty inlines are needed, please drop
> them or provide an explanation in the commit message.

I added the guards for the users who might not 'select PCI_DOE' in their
config. I missed the fact that all the current users of these functions
have 'select PCI_DOE' in their config, hence these inlines would not be
required and can be dropped.

Regards,
Aksh Garg

> Thanks,
>
> Lukas