RE: [PATCH 2/2] iio: orientation: hid-sensor-rotation: fix quaternion alignment

[Zhang, Lixu]

>-----Original Message-----
>From: David Lechner <dlechner@xxxxxxxxxxxx>
>Sent: Sunday, February 15, 2026 5:00 AM
>To: Jonathan Cameron <jic23@xxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>;
>Andy Shevchenko <andy@xxxxxxxxxx>; Jiri Kosina <jikos@xxxxxxxxxx>; Srinivas
>Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
>Cc: linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Jonathan Cameron
><Jonathan.Cameron@xxxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; Lechner,
>David <dlechner@xxxxxxxxxxxx>; Zhang, Lixu <lixu.zhang@xxxxxxxxx>
>Subject: [PATCH 2/2] iio: orientation: hid-sensor-rotation: fix quaternion
>alignment
>
>Restore the alignment of sampled_vals to 16 bytes by using
>IIO_DECLARE_REPEATED_ELEMENT(). This field contains a quaternion value
>which scan_type.repeat = 4 and storagebits = 32. So the alignment must be 16
>bytes to match the assumptions of iio_storage_bytes_for_si() and also to not
>break userspace.
>
>Reported-by: Lixu Zhang <lixu.zhang@xxxxxxxxx>
>Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221077
>Fixes: b31a74075cb4 ("iio: orientation: hid-sensor-rotation: remove
>unnecessary alignment")
>Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>

Tested-by: Lixu Zhang <lixu.zhang@xxxxxxxxx>

Thanks,
-Lixu