Re: [PATCH v2 3/3] arm64: dts: rockchip: Fix vdec register blocks order on RK3588

From: Krzysztof Kozlowski

Date: Tue Feb 24 2026 - 02:22:45 EST


On Mon, Feb 23, 2026 at 09:49:51PM +0200, Cristian Ciocaltea wrote:
> Provide the register blocks in the expected address-based order for

No, there is NO such convention. Don't make up rules.

> vdec0 & vdec1 nodes. This aligns with a similar fix for RK3576 where
> DTC complained about the bus address format.
>
> Fixes: f61731bd6062 ("arm64: dts: rockchip: Add the vdpu381 Video Decoders on RK3588")

Not true, otherwise explain user-visible bug.

> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 7fe9593d8c19..b95129f85aba 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -1355,10 +1355,10 @@ vepu121_3_mmu: iommu@fdbac800 {
>
> vdec0: video-codec@fdc38000 {
> compatible = "rockchip,rk3588-vdec";
> - reg = <0x0 0xfdc38100 0x0 0x500>,
> - <0x0 0xfdc38000 0x0 0x100>,
> + reg = <0x0 0xfdc38000 0x0 0x100>,
> + <0x0 0xfdc38100 0x0 0x500>,
> <0x0 0xfdc38600 0x0 0x100>;

NAK, impacts DTS users without any reason.

Best regards,
Krzysztof