Re: [PATCH 07/62] drm/amdgpu: Unlock a mutex before destroying it

[Christian König]

On 2/23/26 22:50, Bart Van Assche wrote:
> Mutexes must be unlocked before these are destroyed. This has been detected
> by the Clang thread-safety analyzer.
> 
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Cc: Yang Wang <kevinyang.wang@xxxxxxx>
> Cc: Hawking Zhang <Hawking.Zhang@xxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Fixes: f5e4cc8461c4 ("drm/amdgpu: implement RAS ACA driver framework")
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>

Looks reasonable to me, but I'm not very familiar with this code. So only:

Acked-by: Christian König <christian.koenig@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> index afe5ca81beec..db7858fe0c3d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> @@ -641,6 +641,7 @@ static void aca_error_fini(struct aca_error *aerr)
>  		aca_bank_error_remove(aerr, bank_error);
>  
>  out_unlock:
> +	mutex_unlock(&aerr->lock);
>  	mutex_destroy(&aerr->lock);
>  }
>