Re: [PATCH v2 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable

[Linus Walleij]

On Tue, Feb 24, 2026 at 3:35 AM Ethan Tidmore <ethantidmore06@xxxxxxxxx> wrote:

> The handler for the IRQ part of this driver is mpu3050->trig but,
> in the teardown free_irq() is called with handler mpu3050:
>
>         ret = request_threaded_irq(irq,
>                                    mpu3050_irq_handler,
>                                    mpu3050_irq_thread,
>                                    irq_trig,
>                                    mpu3050->trig->name,
>                                    mpu3050->trig);
>
> ...
>
> void mpu3050_common_remove(struct device *dev)
> {
>
> ...
>
>         if (mpu3050->irq)
>                 free_irq(mpu3050->irq, mpu3050);
>         iio_device_unregister(indio_dev);
>         mpu3050_power_down(mpu3050);
> }
>
> Use correct IRQ handler when calling free_irq().
>
> Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope")
> Signed-off-by: Ethan Tidmore <ethantidmore06@xxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij