Re: [PATCH v2 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable

[Andy Shevchenko]

On Mon, Feb 23, 2026 at 08:35:08PM -0600, Ethan Tidmore wrote:
> The handler for the IRQ part of this driver is mpu3050->trig but,
> in the teardown free_irq() is called with handler mpu3050:
> 
> 	ret = request_threaded_irq(irq,
> 				   mpu3050_irq_handler,
> 				   mpu3050_irq_thread,
> 				   irq_trig,
> 				   mpu3050->trig->name,
> 				   mpu3050->trig);

No need to cite the full snippet (we may easily open the file and read that),
it's enough to mention like

	request_threaded_irq(..., mpu3050->trig)

or just in free words without any code.

...

> void mpu3050_common_remove(struct device *dev)
> {
> 
> ...
> 
> 	if (mpu3050->irq)
> 		free_irq(mpu3050->irq, mpu3050);
> 	iio_device_unregister(indio_dev);
> 	mpu3050_power_down(mpu3050);
> }

Ditto.

-- 
With Best Regards,
Andy Shevchenko