Re: [PATCH 1/2] Revert "irqchip/ls-extirq: Use for_each_of_imap_item iterator"

[Ioana Ciornei]

On Tue, Feb 24, 2026 at 01:47:11PM +0100, Herve Codina wrote:
> Hi Ioana,
> 
> On Tue, 24 Feb 2026 13:36:09 +0200
> Ioana Ciornei <ioana.ciornei@xxxxxxx> wrote:
> 
> > This reverts commit 3ac6dfe3d7a2396602b67667249b146504dfbd2a.
> > 
> > The ls-extirq uses interrupt-map but it's a non-standard use documented
> > in fsl,ls-extirq.yaml:
> > 
> >         # The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT
> >         # function to parser interrupt-map. So it doesn't consider '#address-size'
> >         # in parent interrupt controller, such as GIC.
> >         #
> >         # When dt-binding verify interrupt-map, item data matrix is spitted at
> >         # incorrect position. Remove interrupt-map restriction because it always
> >         # wrong.
> > 
> > This means that by using for_each_of_imap_item and the underlying
> > of_irq_parse_imap_parent() on its interrupt-map property will
> > effectively break its functionality
> > 
> > Revert the patch making use of for_each_of_imap_item() in ls-extirq.
> > 
> > Fixes: 3ac6dfe3d7a2 ("irqchip/ls-extirq: Use for_each_of_imap_item iterator")
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> > ---
> >  drivers/irqchip/irq-ls-extirq.c | 47 +++++++++++++++++++++------------
> >  1 file changed, 30 insertions(+), 17 deletions(-)
> 
> Sorry for breaking it when I did 3ac6dfe3d7a2.
> I have missed this non-standard usage of interrupt-map.

No worries. It's hard to spot.

Ioana