Re: [Patch v6 10/22] perf/x86: Enable XMM Register Sampling for Non-PEBS Events

[Mi, Dapeng]

On 2/25/2026 9:11 AM, Chang S. Bae wrote:
> On 2/24/2026 4:55 PM, Mi, Dapeng wrote:
>> Thanks, 'xregs' is a good word. But considering current naming convention
>> in arch/x86/events/core.c, I would add the "x86_pmu" prefix
> Do you know or can explain the purpose of that prefix on every function 
> there? Is it for 'git grep x86_pmu'? But that's probably useful for 
> those in a header file. Looks like just make it longer without good reason.

Per my understanding, the naming prefix "x86_pmu" is to emphasize the
function is a x86-arch generic function instead of a vendor specific PMU
function, like intel_pmu_* or amd_pmu_*, or other architectural PMU functions. 

E.g., there is the generic x86 event enabling function
x86_pmu_enable_event() and the vendor specific event enabling functions,
intel_pmu_enable_event()/amd_pmu_enable_event() in current perf code.

Thanks.

>