Re: [Patch v6 10/22] perf/x86: Enable XMM Register Sampling for Non-PEBS Events

From: Chang S. Bae

Date: Tue Feb 24 2026 - 22:14:31 EST


On 2/24/2026 5:36 PM, Mi, Dapeng wrote:

E.g., there is the generic x86 event enabling function
x86_pmu_enable_event()
Again that's in the header file, which looks okay to me.

Now looking at the file, core.c

get_possible_counter_mask()
reserve_pmc_hardware()
release_pmc_hardware()
set_ext_hw_attr()
precise_br_compat()
add_nr_metric_event()
collect_event()
...

Then all of them violate that naming convention?

There is also another pattern assigning x86_pmu_xxx() to function pointers in struct pmu. Certainly this xsaving function itself isn't the case.