Re: [PATCH v3 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq()
From: Andy Shevchenko
Date: Wed Feb 25 2026 - 06:59:34 EST
On Tue, Feb 24, 2026 at 04:48:18PM -0600, Ethan Tidmore wrote:
> The triggered buffer is initialized before the IRQ is requested. The
> removal path currently calls iio_triggered_buffer_cleanup() before
> free_irq(). This violates the expected LIFO.
>
> Place free_irq() in correct location.
"Place free_irq() in the correct location."
> - Clarify patch purpose
Still doesn't give me enough clarity.
The patch as I read it doesn't move free_irq().
...
But I leave it to native speaker and maintainer to decide. No need to resend.
--
With Best Regards,
Andy Shevchenko