Re: [PATCH v3 0/4] iio: gyro: mpu3050: Multiple bug fixes

From: Andy Shevchenko

Date: Wed Feb 25 2026 - 07:02:52 EST


On Tue, Feb 24, 2026 at 04:48:14PM -0600, Ethan Tidmore wrote:
> This series fixes 4 bugs:
> - Patch 1: Fix free_irq() being called with wrong handler.
> - Patch 2: Added missing free_irq() in an error path.
> - Patch 3: Moved iio_device_register() to end of probe function, in
> doing so had to implement correct error cleanups and place
> iio_device_unregister in beginning of remove callback.
> - Patch 4: free_irq() is after called iio_triggered_buffer_cleanup()
> which breaks LIFO, place it before it.
>
> I plan on doing a proper devm_ conversion of this driver, but went ahead
> and did these fixes so they could be backported.

LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

The commit message in the patch 4 sounds to me as needs an improve,
but I leave this to Jonathan.


--
With Best Regards,
Andy Shevchenko