Re: [PATCH v8 10/18] arm64: dts: qcom: x1e80100: Add MIPI CSI PHY nodes

From: Krzysztof Kozlowski

Date: Thu Feb 26 2026 - 04:43:51 EST


On 26/02/2026 10:30, Bryan O'Donoghue wrote:
> On 26/02/2026 07:11, Krzysztof Kozlowski wrote:
>> On Wed, Feb 25, 2026 at 03:11:27PM +0000, Bryan O'Donoghue wrote:
>>> +
>>> qup_opp_table_100mhz: opp-table-qup100mhz {
>>> compatible = "operating-points-v2";
>>>
>>> @@ -5543,6 +5562,102 @@ cci1_i2c1: i2c-bus@1 {
>>> };
>>> };
>>>
>>> + csiphy0: csiphy@ace4000 {
>>> + compatible = "qcom,x1e80100-csi2-phy";
>>
>> There is no such compatible documented in the kernel, nor in this
>> patchset. Either you combine DTS into driver patchset to solve this, or
>> don't combine DTS at all. DTS cannot go via driver tree.
>
> "b4 shazam <change-id>" should work since
>
> Depends-on:
> https://lore.kernel.org/r/20260225-x1e-csi2-phy-v2-0-7756edb67ea9@xxxxxxxxxx
>
> appears in the series cover, I don't know of any good way to add that
> type of dependency link into a patch.

Standard way how ask every other person to document it. It's even
repeated in every Rob's bot answer - you have changelog to provide the
binding.

But you missed the point - combining here the DTS which still relies on
something else is not helping.

Best regards,
Krzysztof