Re: [PATCH] iio: tsl2772: fix all kernel-doc warnings

[Andy Shevchenko]

On Thu, Feb 26, 2026 at 11:14:05AM -0800, Randy Dunlap wrote:
> On 2/26/26 12:04 AM, Andy Shevchenko wrote:
> > On Wed, Feb 25, 2026 at 09:12:57PM -0800, Randy Dunlap wrote:
> >> Use the correct kernel-doc notation for struct members to eliminate
> >> kernel-doc warnings:
> >>
> >> Warning: include/linux/platform_data/tsl2772.h:88 struct member
> >>  'prox_diode' not described in 'tsl2772_settings'
> >> Warning: include/linux/platform_data/tsl2772.h:88 struct member
> >>  'prox_power' not described in 'tsl2772_settings'
> > 
> > Hmm... I do not see any of the user of this header file.
> > Have you checked if these values are even used?
> > Perhaps we can simply kill all this?
> 
> They are used in drivers/iio/light/tsl2772.c.

It's the same driver. So it's *not* a user of the platform data.

Under 'kill' I meant the following:
- inline the content of the file to the c-file
- recheck the c-file for the unused fields and drop them for good

Alternatively converting c-file to use device properties instead
of platform data.

We have done many times in the past such transformations in other
drivers.

> > But if Jonathan wants to take this as a quick fix to make less
> > warnings appear effective immediately I'm fine with the change
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko