Re: [PATCH] iio: tsl2772: fix all kernel-doc warnings

[Randy Dunlap]

Hi Andy,

On 2/26/26 12:29 PM, Andy Shevchenko wrote:
> On Thu, Feb 26, 2026 at 11:14:05AM -0800, Randy Dunlap wrote:
>> On 2/26/26 12:04 AM, Andy Shevchenko wrote:
>>> On Wed, Feb 25, 2026 at 09:12:57PM -0800, Randy Dunlap wrote:
>>>> Use the correct kernel-doc notation for struct members to eliminate
>>>> kernel-doc warnings:
>>>>
>>>> Warning: include/linux/platform_data/tsl2772.h:88 struct member
>>>>  'prox_diode' not described in 'tsl2772_settings'
>>>> Warning: include/linux/platform_data/tsl2772.h:88 struct member
>>>>  'prox_power' not described in 'tsl2772_settings'
>>>
>>> Hmm... I do not see any of the user of this header file.
>>> Have you checked if these values are even used?
>>> Perhaps we can simply kill all this?

AFAICT all macros and structs and struct members from that header file are used
in tsl2772.c.

>> They are used in drivers/iio/light/tsl2772.c.
> 
> It's the same driver. So it's *not* a user of the platform data.
> 
> Under 'kill' I meant the following:
> - inline the content of the file to the c-file

Would that be "violating" this commit?
commit 436d42c61c3e
Author: Arnd Bergmann <arnd@xxxxxxxx>
Date:   Fri Aug 24 15:22:12 2012 +0200

    ARM: samsung: move platform_data definitions
    
    Platform data for device drivers should be defined in
    include/linux/platform_data/*.h, not in the architecture
    and platform specific directories.

> - recheck the c-file for the unused fields and drop them for good

All used AFAICT.

> Alternatively converting c-file to use device properties instead
> of platform data.

That's your area, I guess.

> We have done many times in the past such transformations in other
> drivers.
> 
>>> But if Jonathan wants to take this as a quick fix to make less
>>> warnings appear effective immediately I'm fine with the change
>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> 
thanks.
-- 
~Randy