Re: [PATCH 2/2] tools/build: Reject unexpected values for LLVM=

[Nicolas Schier]

On Thu, Feb 26, 2026 at 02:45:58PM -0700, Nathan Chancellor wrote:
> On Thu, Feb 26, 2026 at 10:23:58PM +0100, Thomas Weißschuh wrote:
> > Since commit 502678b88cb3 ("kbuild: Reject unexpected values for LLVM=")
> > the regular kbuild rejects unexpected values of LLVM=1 instead of
> > silently treating them as LLVM=1.
> > 
> > Align the tools build to kbuild.
> > 
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > 
> > ---
> > There is no formal maintainer for this file.
> > IMO this change should go through kbuild.
> 
> Ironically I just rejected a tools/ patch going through Kbuild:
> 
>   https://lore.kernel.org/20260225192505.GC2755225@ax162/
> 
> but since there is no formal maintainer, it is the same change done in
> Kbuild, and the risk of fallout is much less than that change, I think
> we can make an exception and take it.

+1

> Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>

Reviewed-by: Nicolas Schier <nsc@xxxxxxxxxx>

-- 
Nicolas