Re: [PATCH 1/2] Documentation/llvm: drop note about LLVM=0

[Nicolas Schier]

On Thu, Feb 26, 2026 at 02:43:49PM -0700, Nathan Chancellor wrote:
> On Thu, Feb 26, 2026 at 10:23:57PM +0100, Thomas Weißschuh wrote:
> > Since commit 502678b88cb3 ("kbuild: Reject unexpected values for LLVM=")
> > LLVM=0 generates an error instead of silently behaving unexpectedly.
> > 
> > Drop the now unnecessary note.
> > 
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> 
> It might be worth keeping the note about LLVM=0 not being the same as
> omitting LLVM altogether, as neither the documentation nor the error
> message will say why that is not a valid value. Maybe:
> 
>   ``LLVM=0`` is not the same as omitting ``LLVM`` altogether. If you
>   only wish to use certain LLVM utilities, use their respective make
>   variables.

Yeah, I think that would be a good thing to add, too.

W/ or w/o:

Reviewed-by: Nicolas Schier <nsc@xxxxxxxxxx>

If nobody complains, I am going to add both patches to kbuild-next
within a few days.

Kind regards,
Nicolas



> I don't feel that strongly about it though. Regardless:
> 
> Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> 
> > ---
> >  Documentation/kbuild/llvm.rst | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
> > index bc8a283bc44b..441d8786fcbc 100644
> > --- a/Documentation/kbuild/llvm.rst
> > +++ b/Documentation/kbuild/llvm.rst
> > @@ -71,10 +71,6 @@ recommend::
> >  
> >  	PATH=/path/to/llvm/:$PATH make LLVM=-14
> >  
> > -``LLVM=0`` is not the same as omitting ``LLVM`` altogether, it will behave like
> > -``LLVM=1``. If you only wish to use certain LLVM utilities, use their
> > -respective make variables.
> > -
> >  The same value used for ``LLVM=`` should be set for each invocation of ``make``
> >  if configuring and building via distinct commands. ``LLVM=`` should also be set
> >  as an environment variable when running scripts that will eventually run
> > 
> > -- 
> > 2.53.0
> > 

-- 
Nicolas