Re: [PATCH] iio: adc: ade9000: fix wrong macro names in ADE9000_ST_ERROR

[Jonathan Cameron]

On Fri, 27 Feb 2026 16:44:47 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Fri, Feb 27, 2026 at 02:52:45PM +0400, Giorgi Tchankvetadze wrote:
> > On Fri, Feb 27, 2026 at 2:33 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxx> wrote:
> >   
> > > What about the current code that uses it? Is it even in use currently?
> > >Please, elaborate more in the commit message that we clearly understand
> > >that you spent time and investigated code and/or datasheet before crafting
> > >this change.  
> > 
> > Hi Andy. Thanks for the feedback !
> > The macro is currently unused in the driver, so this does not cause
> > a build failure.  
> 
> Drop it then?
Agreed.  I'm generally in favour of complete definitions of the fields in
a register if any of them are used.  However, in this case it's a define
of a mask covering multiple fields that we have no use for.

So drop it for now. It can come back in a patch that uses it.

Thanks,

Jonathan

> 
> > Reference: ADE9000 datasheet (Rev. B, Page 61), STATUS1 register (0x403),
> > bits 28-31 define ERROR0 through ERROR3 status flags.  
> 
> Yes, good, this should be in the commit message.
>