Re: [PATCH net-next 7/8] net: dsa: lan9645x: add mac table integration

From: Jens Emil Schulz Ostergaard

Date: Thu Mar 05 2026 - 08:22:47 EST


On Wed, 2026-03-04 at 16:34 +0100, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> > > > @@ -6,3 +6,4 @@ mchp-lan9645x-objs := lan9645x_main.o \
> > > > lan9645x_port.o \
> > > > lan9645x_phylink.o \
> > > > lan9645x_vlan.o \
> > > > + lan9645x_mac.o \
> > >
> > > Is there some particular ordering here? Because it's surely not
> > > alphabetical.
> > >
> >
> > I just add new files at the end, I thought that made the most sense. Should they be
> > sorted by name?
>
> This is part of the whole 'sorted' story of lists in Linux. By keeping
> lists sorted, insertions are spread out across the list. That reduced
> merge conflicts. Within one driver, conflicts are less likely, but
> always adding to the end of Makefile, Kconfig, core code, etc will see
> merge conflicts if we have two developers adding drivers at the same
> time.
>
> So if you have any sort of list of items, please try to keep it
> sorted.
>
> Andrew

Ok that makes a lot of sense. I will make sure my lists are sorted.

Thanks,
Emil