Re: [PATCH 3/5] USB: ljca: drop redundant interface reference

From: Sakari Ailus

Date: Thu Mar 05 2026 - 08:23:29 EST


Hi Johan,

Thanks for the patch.

On Thu, Mar 05, 2026 at 12:15:09PM +0100, Johan Hovold wrote:
> Driver core holds a reference to the USB interface while it is bound to
> a driver and there is no need to take another reference unless the
> interface is needed after disconnect.
>
> Drop the redundant interface reference to reduce cargo culting, make it
> easier to spot drivers where an extra reference is needed, and reduce
> the risk of memory leaks when drivers fail to release it.
>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

--
Kind regards,

Sakari Ailus