Re: [PATCH v1 01/13] dt-bindings: soc: starfive: Add StarFive JHB100 syscon modules

[Krzysztof Kozlowski]

On Thu, Apr 02, 2026 at 10:49:33PM -0700, Changhuang Liang wrote:
> Add documentation to describe StarFive JHB100 SoC System Controller
> Registers.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> ---
>  .../soc/starfive/starfive,jhb100-syscon.yaml  | 140 ++++++++++++++++++
>  MAINTAINERS                                   |   5 +
>  2 files changed, 145 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jhb100-syscon.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jhb100-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/starfive,jhb100-syscon.yaml
> new file mode 100644
> index 000000000000..c0e1f6f68fa2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jhb100-syscon.yaml
> @@ -0,0 +1,140 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/starfive/starfive,jhb100-syscon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive JHB100 SoC system controller
> +
> +maintainers:
> +  - Kevin Xie <kevin.xie@xxxxxxxxxxxxxxxx>
> +  - Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> +
> +description:
> +  The StarFive JHB100 SoC system controller provides register information such
> +  as offset, mask and shift to configure related modules such as PLL and PCIe.

How a MMIO based device can provide a MMIO information? What exactly
does it provide? Register where the value is the offset of other
register?

> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - starfive,jhb100-pcierp-syscon
> +              - starfive,jhb100-per0-syscon
> +              - starfive,jhb100-per1-syscon
> +              - starfive,jhb100-sys0-syscon
> +          - const: syscon
> +          - const: simple-mfd
> +      - items:
> +          - enum:
> +              - starfive,jhb100-b2h-syscon
> +              - starfive,jhb100-gpu-syscon
> +              - starfive,jhb100-h2b-syscon
> +              - starfive,jhb100-host-syscon
> +              - starfive,jhb100-husb-syscon
> +              - starfive,jhb100-husbcmn-syscon
> +              - starfive,jhb100-husbd-syscon
> +              - starfive,jhb100-npu-syscon
> +              - starfive,jhb100-pcieep-ecsr-syscon
> +              - starfive,jhb100-pcierp-ecsr-syscon
> +              - starfive,jhb100-per2-syscon
> +              - starfive,jhb100-per3-syscon

Hm? per2 as starfive,jhb100-per2crg is a separate device, so how can it
be also a syscon?

> +              - starfive,jhb100-strap-syscon
> +              - starfive,jhb100-sys1-syscon
> +              - starfive,jhb100-sys2-syscon
> +              - starfive,jhb100-usb-syscon
> +              - starfive,jhb100-vout-syscon
> +          - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  clock-controller:
> +    $ref: /schemas/clock/starfive,jhb100-pll.yaml#
> +    type: object

Why are you mixing MMIO and non-MMIO devices here/

> +
> +  "#address-cells":
> +    const: 2
> +
> +  "#size-cells":
> +    const: 2
> +
> +  ranges: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - starfive,jhb100-per0-syscon
> +              - starfive,jhb100-per1-syscon
> +              - starfive,jhb100-sys0-syscon
> +    then:
> +      required:
> +        - clock-controller
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: starfive,jhb100-sys0-syscon
> +    then:
> +      required:
> +        - "#address-cells"
> +        - "#size-cells"
> +        - ranges
> +      patternProperties:
> +        "^chipid@[0-9a-f]+$":
> +          $ref: /schemas/hwinfo/starfive,jhb100-socinfo.yaml#
> +          type: object
> +
> +

Just one blank line

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: starfive,jhb100-pcierp-syscon
> +    then:
> +      required:
> +        - "#address-cells"
> +        - "#size-cells"
> +        - ranges
> +      patternProperties:
> +        "^reset-controller@[0-9a-f]+$":
> +          $ref: /schemas/reset/starfive,jhb100-reset-pcierp.yaml#

There is no such file so nothing here is testable or even possible to
apply.

Following my first question, I don't understand why this is even a
child.

Anyway, properties must be defined in top-level.

Best regards,
Krzysztof