Re: [PATCH net-next 1/3] psp: add crypt-offset and spi-threshold get/set attributes

From: Akhilesh Samineni

Date: Fri Apr 10 2026 - 15:36:43 EST


On Wed, Apr 8, 2026 at 6:34 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 07 Apr 2026 17:37:41 -0400 Willem de Bruijn wrote:
> > > + if (info->attrs[PSP_A_DEV_CRYPT_OFFSET])
> > > + new_config.crypt_offset =
> > > + nla_get_u8(info->attrs[PSP_A_DEV_CRYPT_OFFSET]);
> >
> > PSP defines a 6-bit field in 4 octet units. Does this need bounds checking?
>
> More fundamentally, were we to support this -- is it a device property
> or an assoc property?

It's a device property. All associations under the device will share
the same crypt-offset.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature