Re: [PATCH net-next 1/3] psp: add crypt-offset and spi-threshold get/set attributes
From: Jakub Kicinski
Date: Fri Apr 10 2026 - 17:02:56 EST
On Sat, 11 Apr 2026 01:06:06 +0530 Akhilesh Samineni wrote:
> On Wed, Apr 8, 2026 at 6:34 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> > On Tue, 07 Apr 2026 17:37:41 -0400 Willem de Bruijn wrote:
> > > PSP defines a 6-bit field in 4 octet units. Does this need bounds checking?
> >
> > More fundamentally, were we to support this -- is it a device property
> > or an assoc property?
>
> It's a device property. All associations under the device will share
> the same crypt-offset.
I don't think there's anything in the spec that says the crypto
offset is device level.
At the very least every L4 proto may want to have a different offset.
We should probably hold off adding this until a real user appears.