Re: [RFC 0/2] openrisc: Add support for KProbes

[Sahil]

Hi Masami,

On 4/15/26 12:18 PM, Masami Hiramatsu (Google) wrote:
> Hi Sahil,
>
> On Wed,  8 Apr 2026 00:26:48 +0530
> Sahil Siddiq <sahilcdq0@xxxxxxxxx> wrote:
>
> > Hi,
> >
> > This series adds basic support for KProbes on OpenRISC. There are
> > a few changes that I would still like to add and test before this
> > can be considered for merging. I was hoping to get some feedback on
> > the changes made so far. The implementation in this series is based
> > on KProbes for LoongArch, MIPS and RISC-V.
>
> Thanks for porting!
> Sashiko reviewed this series, can you check the comments?
> Most comments (not all) look reasonable to me.
>
> https://sashiko.dev/#/patchset/20260407185650.79816-1-sahilcdq0%40gmail.com

Thank you for the link. I'll address the review comments.

> Generally, please make better use of macros rather than magic values
> in your code to make it easier to understand.
> Also, use GENMASK() and BIT() macro to define bitmasks and bit.

Understood. I'll keep that in mind in future patches.

> Thanks,

Thanks,
Sahil