Re: [PATCH v2] nvme-auth: Include SC_C in RVAL controller hash

From: Christoph Hellwig

Date: Thu Apr 16 2026 - 01:16:38 EST


On Thu, Apr 16, 2026 at 09:08:24AM +1000, alistair23@xxxxxxxxx wrote:
> From: Alistair Francis <alistair.francis@xxxxxxx>
>
> Section 8.3.4.5.5 of the NVMe Base Specification 2.1 describes what is
> included in the Response Value (RVAL) hash and SC_C should be included.
> Currently we are hardcoding 0 instead of using the correct SC_C value.
>
> Update the host and target code to use the SC_C when calculating the
> RVAL instead of using 0.

This looks correct. But I guess this breaks existing implementations
in the wild now?