Re: [PATCH net,v2 1/1] net: stmmac: Update default_an_inband before passing value to phylink_config

[KhaiWenTan]

On 4/16/2026 4:12 PM, Paolo Abeni wrote:

> On 4/13/26 4:03 AM, KhaiWenTan wrote:
> > get_interfaces() will update both the plat->phy_interfaces and
> > mdio_bus_data->default_an_inband based on reading a SERDES register. As
> > get_interfaces() will be called after default_an_inband had already been
> > read, dwmac-intel regressed as a result with incorrect default_an_inband
> > value in phylink_config.
> >
> > Therefore, we moved the priv->plat->get_interfaces() to be executed first
> > before assigning mdio_bus_data->default_an_inband to
> > config->default_an_inband to ensure default_an_inband is in correct value.
> >
> > Fixes: d3836052fe09 ("net: stmmac: intel: convert speed_mode_2500() to get_interfaces()")
> > Signed-off-by: KhaiWenTan <khai.wen.tan@xxxxxxxxxxxxxxx>
> Since Jakub sent the net-next PR and forwarded the trees, this patch
> does not apply anymore. Please rebase and repost. You can retain
> Russell's reviewed-by tag.
>
> Thanks,
>
> Paolo

Thank you Paolo, will be rebasing the patch and update a v3.