Re: [PATCH v2] staging: media: atomisp: gc2235: prefer usleep_range over msleep

[Sakari Ailus]

On Thu, Mar 19, 2026 at 08:42:47PM +0000, Abhai Kollara wrote:
> The gc2235 driver uses msleep(5) during power-up. msleep() is often
> imprecise for durations under 20ms. Replace it with usleep_range()
> to provide better precision.
> 
> Signed-off-by: Abhai Kollara <abhai@xxxxxxxxxxxxxx>
> ---
>  drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> index d3414312e1de..db5e007efc56 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> @@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
>  			goto fail_power;
>  	}
>  
> -	msleep(5);
> +	usleep_range(5000, 6000);

I'd rather use fsleep() here.

>  	return 0;
>  
>  fail_clk:

-- 
Sakari Ailus