Re: [PATCH] crypto: octeontx2: fix IRQ vector leak in otx2_cptpf_probe()

[Guangshuo Li]

Hi Herbert,

Thanks for the review.

On Thu, 16 Apr 2026 at 17:20, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Good catch.  But what about the remove path, shouldn't the vectors
> be freed there as well?
>
> Thanks,
> --

I investigated this further after your comment and found that this
driver relies on the PCI managed cleanup associated with
pcim_enable_device(). In other words, the IRQ vectors allocated by
pci_alloc_irq_vectors() are already reclaimed through that path, so an
explicit pci_free_irq_vectors() is not needed in remove/error unwind
here.

So this patch is not needed. I'll drop it.

Thanks,
Guangshuo