Re: [PATCH] spi: mtk-snfi: fix memory leak in probe

[Mark Brown]

On Thu, Apr 16, 2026 at 07:46:20PM +0800, Felix Gu wrote:

> ms->buf is allocated in mtk_snand_setup_pagefmt() but was not freed on
> the following error paths.

>  	ret = nand_ecc_register_on_host_hw_engine(&ms->ecc_eng);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to register ecc engine.\n");
> -		goto release_ecc;
> +		goto free_buf;
>  	}
>  
>  	ret = devm_add_action_or_reset(&pdev->dev, mtk_unregister_ecc_engine,
>  				       &ms->ecc_eng);
>  	if (ret) {
>  		dev_err_probe(&pdev->dev, ret, "failed to add ECC unregister action\n");
> -		goto release_ecc;
> +		goto free_buf;
>  	}
>  
>  	ctlr->num_chipselect = 1;

What about spi_register_controller() failures?

Attachment: signature.asc
Description: PGP signature