Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: add max20830

[Conor Dooley]

On Thu, Apr 16, 2026 at 11:01:49AM -0700, Guenter Roeck wrote:
> On Thu, Apr 16, 2026 at 04:51:37PM +0100, Conor Dooley wrote:
> > On Thu, Apr 16, 2026 at 03:59:10PM +0800, Alexis Czezar Torreno wrote:
> > > Add device tree documentation for MAX20830 step-down DC-DC switching
> > > regulator with PMBus interface.
> > > 
> > > Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@xxxxxxxxxx>
> > > ---
> > >  .../bindings/hwmon/pmbus/adi,max20830.yaml         | 61 ++++++++++++++++++++++
> > >  MAINTAINERS                                        |  7 +++
> > >  2 files changed, 68 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..8b3ec1ffa0c9460de2122f6606ce3dcbcdfbbcc7
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
> > > @@ -0,0 +1,61 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/hwmon/pmbus/adi,max20830.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices MAX20830 Step-Down Switching Regulator with PMBus
> > > +
> > > +maintainers:
> > > +  - Alexis Czezar Torreno <alexisczezar.torreno@xxxxxxxxxx>
> > > +
> > > +description: |
> > > +  The MAX20830 is a fully integrated step-down DC-DC switching regulator with
> > > +  PMBus interface. It provides 2.7V to 16V input, 0.4V to 5.8V adjustable
> > > +  output, and up to 30A output current. It allows monitoring of input/output
> > > +  voltage, output current and temperature through the PMBus serial interface.
> > > +  Datasheet:
> > > +    https://www.analog.com/en/products/max20830.html
> > > +
> > > +allOf:
> > > +  - $ref: /schemas/regulator/regulator.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: adi,max20830
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > 
> > On the previous version, you got an LLM comment about not having the
> > interrupts property amongst other things.
> > I think the other things got implemented, but I didn't see any reply to
> > the bot about that?
> > I think the answer is that it shouldn't because the pin it referenced
> > doesn't exist, but when looking at the schematic I have to wonder if
> 
> I had to look this up in the datasheet. A SMBus chip with no alert pin is
> a bit odd, but you are correct.
> 
> > there should be an interrupts property for dealing with "pgood"?
> > 
> FWIW, I have never seen that. Normally such pins are used to take devices
> out of reset.

It's an output on this device seemingly. I don't care if the driver
ignores it, but for completeness (and we like completeness with
bindings) I think it should be documented as an interrupt or gpio.

Attachment: signature.asc
Description: PGP signature