Re: [PATCH v6] nvme: Skip trace complete_rq on host path error

From: Chaitanya Kulkarni

Date: Thu Apr 16 2026 - 17:38:12 EST


On 4/15/26 18:07, 전민식 wrote:
> From cfd386c2d769552c4dd32ec8ff5233ef34f9830d Mon Sep 17 00:00:00 2001
> From: Minsik Jeon<hmi.jeon@xxxxxxxxxxx>
> Date: Thu, 16 Apr 2026 10:43:00 +0900
> Subject: [PATCH v6] nvme: Skip trace complete_rq on host path error
>
> we were checking host_pathing_error before calling nvme_setup_cmd().
> This is caused the command setup to be skipped entirely when a pathing
> error occurred, making it impossible to trace the nvme command via
> trace_cmd nvme_complete_rq().
>
> As a result, when nvme_complete_rq() logged a completion with cmdid=0,
> it was impossible to correlate the completion with the nvme command
> request.
>
> This patch Skip trace_nvme_complete_rq() on NVMe host path error.
>
> Co-authored-by: Beomsoo Kim<beomsooo.kim@xxxxxxxxxxx>
> Co-authored-by: Eunsoo Lee<euns212.lee@xxxxxxxxxxx>
> Co-authored-by: Steven Seungcheol Lee<sc108.lee@xxxxxxxxxxx>
> Signed-off-by: Minsik Jeon<hmi.jeon@xxxxxxxxxxx>
> ---

Is it possible to send this patch using git send-email ?
Also, do you see any performance difference after this change ?
I don't expect any but it's better to document if any since
this is in the fast path.

-ck