Re: [PATCH v3] nvme: expose TLS mode
From: Keith Busch
Date: Thu Apr 16 2026 - 18:07:36 EST
On Wed, Apr 08, 2026 at 06:19:56PM +0200, Daniel Wagner wrote:
> It is not possible to determine the active TLS mode from the
> presence or absence of sysfs attributes like tls_key,
> tls_configured_key, or dhchap_secret.
>
> With the introduction of the concat mode and optional DH-CHAP
> authentication, different configurations can result in identical
> sysfs state. This makes user space detection unreliable.
>
> Expose the TLS mode explicitly to allow user space to
> unambiguously identify the active configuration and avoid
> fragile heuristics in nvme-cli.
I'd applied v2 earlier, but I'll force push this one instead since we
haven't done a pull request since then.