Re: [PATCH v4 1/2] drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi
From: Doug Anderson
Date: Thu Apr 16 2026 - 22:52:22 EST
Hi,
On Thu, Apr 16, 2026 at 12:39 AM Avinal Kumar <avinal.xlvii@xxxxxxxxx> wrote:
>
> @@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx,
> }
> EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_scanline_multi);
>
> +/**
> + * mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command
> + * @ctx: Context for multiple DSI transactions
> + *
> + * Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that
> + * makes it convenient to make serial calls in a row.
Between v3 and v4, you changed:
make several calls in a row
to
make serial calls in a row
Is there a reason why? Not that it matters a whole lot, but the old
wording seemed fine and it matches the wording in the description of
all of the other _multi functions.
Other than that weird nit, this looks OK to me:
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
I'm pretty curious why you changed it between v3 and v4, though.
-Doug