Re: [PATCH v4 2/2] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions

[Doug Anderson]

Hi,

On Thu, Apr 16, 2026 at 7:51 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> On Thu, Apr 16, 2026 at 12:39 AM Avinal Kumar <avinal.xlvii@xxxxxxxxx> wrote:
> >
> > Changes the panasonic-vvx10f034n00 panel to multi
> > style functions for improved error handling and
> > removes redundant error printout.
>
> nit: Linux folks generally like the "imperative" statements. So the
> above would be better as:
>
> Change the panasonic-vvx10f034n00 panel to multi style functions for
> improved error handling and remove redundant error printout.
>
> In other words, use "change" not "changes" and "remove" not "removes".
>
>
> > @@ -95,7 +104,6 @@ static int wuxga_nt_panel_prepare(struct drm_panel *panel)
> >
> >         ret = wuxga_nt_panel_on(wuxga_nt);
> >         if (ret < 0) {
> > -               dev_err(panel->dev, "failed to set panel on: %d\n", ret);
> >                 goto poweroff;
> >         }
>
> Now that you've removed the error printout (and thus it's a one-liner
> inside the "if" test), you need to remove the braces. Linux style
> guidelines are pretty strict about this. Hopefully it's pretty easy to
> spin a v5 with that? Otherwise, this looks fine to me.

Actually, looking at it one more time, the code should probably just look like:

ret = wuxga_nt_panel_on(wuxga_nt);
if (ret < 0)
  regulator_disable(wuxga_nt->supply);

return ret;

The "goto" is pretty overkill here.