Re: [PATCH 1/2] Revert "nvmet-tcp: Don't free SQ on authentication success"

[Hannes Reinecke]

On 4/17/26 02:48, alistair23@xxxxxxxxx wrote:
> From: Alistair Francis <alistair.francis@xxxxxxx>
>
> In an attempt to fix REPLACETLSPSK we stopped freeing the secrets on
> successful connections. This resulted in memory leaks in the kernel, so
> let's revert the commit. A improved fix is being developed to just avoid
> clearing the tls_key variable.
>
> This reverts commit 2e6eb6b277f593b98f151ea8eff1beb558bbea3b.
>
> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx>
> ---
>   drivers/nvme/target/fabrics-cmd-auth.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich