Re: [PATCH v3] iio: frequency: ad9834: clean up includes

[Andy Shevchenko]

On Thu, Apr 16, 2026 at 09:32:40AM +0000, Joshua Crofts wrote:
> Cleanup include headers by removing proxy kernel.h header and
> unnecessary list.h, interrupt.h, workqueue.h and slab.h headers. Added
> additional headers that were previously included from kernel.h.
> 
> Verified using the include-what-you-use tool.

I'm wondering why in previous round the tool haven't noticed what I did...

...

> +#include <linux/bits.h>
>  #include <linux/clk.h>
> -#include <linux/interrupt.h>
> -#include <linux/workqueue.h>
> -#include <linux/device.h>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
> -#include <linux/list.h>
> -#include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
> +#include <linux/dev_printk.h>
>  #include <linux/err.h>
> +#include <linux/kstrtox.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/spi/spi.h>

> +#include <linux/string.h>

Hmm... What's used for here?

> +#include <linux/sysfs.h>
> +#include <linux/types.h>
> +
> +#include <asm/byteorder.h>
>  #include <asm/div64.h>

-- 
With Best Regards,
Andy Shevchenko