Re: [PATCH] mac80211: minstrel_ht: bound debugfs stats output construction
From: Johannes Berg
Date: Fri Apr 17 2026 - 04:03:28 EST
On Fri, 2026-04-17 at 15:56 +0800, Pengpeng Hou wrote:
> minstrel_ht_stats_open() and minstrel_ht_stats_csv_open() build their
> entire debugfs outputs in a fixed 32 KiB heap buffer and append each row
> with raw sprintf() calls.
>
> The number of rows depends on the current-tree minstrel group/rate
> layout, and the final WARN_ON() only checks the accumulated length after
> the writes have already happened.
Which statically cannot happen, so no.
Please review your changes for actually being relevant *before* posting
them, otherwise I'm just going to start rejecting *all* your patches
without looking.
johannes