Re: [PATCH RFC 3/7] media: qcom: iris: add helpers for 8bit and 10bit formats

[Neil Armstrong]

On 4/17/26 09:23, Dikshita Agarwal wrote:
> On 4/8/2026 10:13 PM, Neil Armstrong wrote:
> > To simplify code checking for pixel formats, add helpers to
> > check for 8bit and 10bit formats.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   drivers/media/platform/qcom/iris/iris_utils.c | 12 ++++++++++++
> >   drivers/media/platform/qcom/iris/iris_utils.h |  2 ++
> >   2 files changed, 14 insertions(+)
> >
> > diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c
> > index 26f51a0ccd04..c75dcb8e671e 100644
> > --- a/drivers/media/platform/qcom/iris/iris_utils.c
> > +++ b/drivers/media/platform/qcom/iris/iris_utils.c
> > @@ -40,6 +40,18 @@ bool iris_split_mode_enabled(struct iris_inst *inst)
> >   		inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C;
> >   }
> >   
> > +bool iris_fmt_is_8bit(__u32 pixelformat)
> > +{
> > +	return pixelformat == V4L2_PIX_FMT_NV12 ||
> > +		pixelformat == V4L2_PIX_FMT_QC08C;
> > +}
> > +
> > +bool iris_fmt_is_10bit(__u32 pixelformat)
> > +{
> > +	return pixelformat == V4L2_PIX_FMT_P010 ||
> > +		pixelformat == V4L2_PIX_FMT_QC10C;
> > +}
>
> A similar check is required in the current first patch of the series. So
> you can move this patch earlier in the series?

Ack

> Thanks,
> Dikshita