Re: [PATCH] PCI: eswin: Fix resource leak on dw_pcie_host_init() failure
From: Felix Gu
Date: Fri Apr 17 2026 - 06:19:07 EST
On Fri, Apr 17, 2026 at 5:35 PM Manivannan Sadhasivam <mani@xxxxxxxxxx> wrote:
>
> Error path is really messed up. On pm_runtime_get_sync() failure, it should
> go to 'err_free_ports' and on dw_pcie_host_init() failure, it should go to
> err_pm_runtime_put.
>
> - Mani
>
> --
> மணிவண்ணன் சதாசிவம்
Hi Mani,
For pm_runtime_get_sync() failure, it still needs a pm_runtime_put().
So it doesn't need two labels here.
Best regards,
Felix Gu