Re: [PATCH v3 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt

[Luka Gejak]

On Fri Apr 17, 2026 at 11:54 AM CEST, Maksym Pikhotskyi wrote:
> The null-pointer-guard was incorrect, returning _FAIL on valid pointer.
> Invert the guard, so it returns _FAIL on invalid pointer.
>
> Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check")
> Reported-by: Luka Gejak <luka.gejak@xxxxxxxxx>
> Closes: https://lore.kernel.org/linux-staging/E4BF62EF-C6F6-431F-8EDC-77C1E613E66B@xxxxxxxxx/
> Reviewed-by: Dan Carpenter <error27@xxxxxxxxx>
> Signed-off-by: Maksym Pikhotskyi <mpikhotskyi@xxxxxxxxx>
> ---
> v2: rebase on staging-next. Split into a series of patches.
> v3: add Reported-by, Closes and Reviewed-by tags.
> ---
>  drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index a00504ff2910..f467cb5b1dca 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -1212,7 +1212,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe)
>  	if (prxattrib->encrypt != _AES_)
>  		return _SUCCESS;
>  	stainfo = rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]);
> -	if (stainfo)
> +	if (!stainfo)
>  		return _FAIL;
>  	if (is_multicast_ether_addr(prxattrib->ra)) {
>  		static unsigned long start;

LGTM.

Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>

Best regards,
Luka Gejak