Re: [PATCH] ASoC: ES8389: convert to devm_clk_get_optional() to get clock

[Uwe Kleine-König]

Hello,

On Fri, Apr 17, 2026 at 06:53:14PM +0800, Li Jian wrote:
> When enabling ES8390 via ACPI description, es8389 would fail to
> obtain a clock source, causing the driver to fail to initialize.
> This was not an issue with older kernels, but since commit
> abae8e57e49a ("clk: generalize devm_clk_get() a bit"),
> devm_clk_get() would return an error pointer when a clock source
> was not detected (instead of falling back to a static clock),
> causing the driver to fail early.
> 
> Use devm_clk_get_optional() instead to return to the previous
> behaviour, allowing the use of a static clock source.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit")

Are you sure you identified the breaking commit correctly? I intended
the patch not to introduce any semantic change, and even with your claim
I don't spot the issue in abae8e57e49a.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature