[PATCH v4 0/8] gpu: nova-core: gsp: add RM control command infrastructure
From: Eliot Courtney
Date: Fri Apr 17 2026 - 11:35:36 EST
Add the infrastructure for sending RM control RPCs. This is needed e.g.
for channel allocation.
This series adds:
- `NV_STATUS` bindings and wrapping `GspMsgRmStatus` and similar enums,
used by generic RPCs and RM control RPCs.
- The necessary bindings for the RM control RPCs.
- `RmControlMsgFunction` to identify individual control commands, like
`MsgFunction` for GSP commands.
- `SBufferIter::read_to_vec` (using KVVec) for reading large RPC payloads
- A typed `RmControl` command that can send RM control commands.
Each new RM control command can be added by extending
`RmControlMsgFunction`, adding the bindings and wrappers for their
parameters, and writing a type-safe wrapper to send and receive the
reply for the RM control rpc, using `RmControl`.
This series applies on latest drm-rust-next at the listed commit.
Signed-off-by: Eliot Courtney <ecourtney@xxxxxxxxxx>
---
Changes in v4:
- Collect Reviewed-by on patches that haven't changed too much
- Split NvStatus enum into GspMsgRmStatus/Warning/Error
- Added GspRpcError for Cmdq errors
- Log NvStatus warnings
- Exhaustively match for NvStatus error -> errno errors
- Change a few NvStatus->errno mappings to match openrm
- Drop fault method buffer size patches
- Link to v3: https://patch.msgid.link/20260325-rmcontrol-v3-0-f3101093484e@xxxxxxxxxx
Changes in v3:
- Remove `send_rm_control` in favour of a typed `RmControl`
- Print out fault method buffer size at gsp boot
- Remove Reviewed-by and Tested-by on some patches that have changed
substantively.
- Link to v2: https://lore.kernel.org/r/20260318-rmcontrol-v2-0-9a9fa6f1c4c3@xxxxxxxxxx
Changes in v2:
- Introduce typed Handle<T> for RM objects.
- Improve naming
- Improve doc comments
- Change SBufferIter to always use KVVec
- flush_into_kvec -> read_to_vec
- Rebased on latest cmdq locking
- Link to v1: https://lore.kernel.org/r/20260227-rmcontrol-v1-0-86648e4869f9@xxxxxxxxxx
---
Eliot Courtney (8):
gpu: nova-core: gsp: add NV_STATUS error code bindings
gpu: nova-core: gsp: add GSP-RM status types
gpu: nova-core: gsp: add GspRpcError for Cmdq RPC error handling
gpu: nova-core: gsp: expose GSP-RM internal client and subdevice handles
gpu: nova-core: gsp: add RM control RPC structure binding
gpu: nova-core: gsp: add types for RM control RPCs
gpu: nova-core: use KVVec for SBufferIter flush
gpu: nova-core: gsp: add RM control command infrastructure
drivers/gpu/nova-core/gsp.rs | 1 +
drivers/gpu/nova-core/gsp/cmdq.rs | 112 +++--
drivers/gpu/nova-core/gsp/commands.rs | 71 ++-
drivers/gpu/nova-core/gsp/fw.rs | 544 +++++++++++++++++++++-
drivers/gpu/nova-core/gsp/fw/commands.rs | 19 +-
drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs | 156 +++++++
drivers/gpu/nova-core/gsp/fw/rm.rs | 90 ++++
drivers/gpu/nova-core/gsp/rm.rs | 3 +
drivers/gpu/nova-core/gsp/rm/commands.rs | 155 ++++++
drivers/gpu/nova-core/gsp/sequencer.rs | 9 +-
drivers/gpu/nova-core/sbuffer.rs | 6 +-
11 files changed, 1117 insertions(+), 49 deletions(-)
---
base-commit: a7a080bb4236ebe577b6776d940d1717912ff6dd
change-id: 20260225-rmcontrol-bd8a06fc3a0d
Best regards,
--
Eliot Courtney <ecourtney@xxxxxxxxxx>