Re: [PATCH 0/8] drm/imagination: Job submission fixes and cleanup

[Robert Nelson]

On Mon, Mar 30, 2026 at 3:21 AM Alessio Belle <alessio.belle@xxxxxxxxxx> wrote:
>
> The first two commits fix rare bugs and should be backported to stable
> branches.

Yeap, that triggered on BeaglePlay v7.0.0, Mesa 26.1.0-rc1 and xserver
21.1.20-1 overnight..  testing now (and updating xserver to 21.1.22 as
more glamor changes)..

https://gist.github.com/RobertCNelson/5e1dcf4c648a5bffaaf970c5a50e5c96

Regards,

>
> The rest is an attempt to cleanup and document the code to make it
> a bit easier to understand.
>
> Signed-off-by: Alessio Belle <alessio.belle@xxxxxxxxxx>
> ---
> Alessio Belle (8):
>       drm/imagination: Count paired job fence as dependency in prepare_job()
>       drm/imagination: Fit paired fragment job in the correct CCCB
>       drm/imagination: Skip check on paired job fence during job submission
>       drm/imagination: Rename pvr_queue_fence_is_ufo_backed() to reflect usage
>       drm/imagination: Rename fence returned by pvr_queue_job_arm()
>       drm/imagination: Move repeated job fence check to its own function
>       drm/imagination: Update check to skip prepare_job() for fragment jobs
>       drm/imagination: Minor improvements to job submission code documentation
>
>  drivers/gpu/drm/imagination/pvr_job.c              |   8 +-
>  drivers/gpu/drm/imagination/pvr_queue.c            | 154 +++++++++++++--------
>  drivers/gpu/drm/imagination/pvr_queue.h            |   2 +-
>  .../gpu/drm/imagination/pvr_rogue_fwif_shared.h    |  10 +-
>  drivers/gpu/drm/imagination/pvr_sync.c             |   8 +-
>  drivers/gpu/drm/imagination/pvr_sync.h             |   2 +-
>  6 files changed, 110 insertions(+), 74 deletions(-)
> ---
> base-commit: 3bce3fdd1ff2ba242f76ab66659fff27207299f1
> change-id: 20260330-job-submission-fixes-cleanup-83e01196c3e9
>
> Best regards,
> --
> Alessio Belle <alessio.belle@xxxxxxxxxx>
>
>


-- 
Robert Nelson
https://rcn-ee.com/